Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maps: how to visualise when either nodes.geojson or spans.geojson fail to convert (but not both) #45

Closed
lgs85 opened this issue Nov 16, 2022 · 3 comments

Comments

@lgs85
Copy link

lgs85 commented Nov 16, 2022

Apologies @odscjames @duncandewhurst if this is duplicated as pushed for time and wanted to log things I'm picking up while demoing.

Looking at this example where one node type has been changed to a non-standard entry, I'm getting a greyed out map with non-functioning zoom buttons. Sometimes the span is plotted for me and sometimes not (this might be a function of my browser and poor wifi). It would be good to make sure that we get consistent behaviour in this scenario, which I expect will be a common one.

@lgs85
Copy link
Author

lgs85 commented Nov 16, 2022

possible overlap with #6

@odscjames
Copy link
Collaborator

I see from the link the original input was JSON.

when either nodes.geojson or spans.geojson fail to convert (but not both)

IMO this shouldn't be a situation we deal with - either the JSON->GeoJSON should work and produce both valid nodes & spans files or it should just break.

how to visualise

#24 is the issue for that.

where one node type has been changed to a non-standard entry

Logged here Open-Telecoms-Data/lib-cove-ofds#39

Also related to Open-Telecoms-Data/lib-cove-ofds#27 which we haven't had a lot of time to work on!

if this is duplicated as pushed for time

No worries - but if you are happy this is logged elsewhere can we close this one?

@lgs85
Copy link
Author

lgs85 commented Nov 16, 2022

Thanks James, all looks good.

@lgs85 lgs85 closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants