Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbos v32 debug #2671

Closed
wants to merge 25 commits into from
Closed

Arbos v32 debug #2671

wants to merge 25 commits into from

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Sep 13, 2024

This does only initial work to declare the existance of a (currently debug-only) arbos v32, under the constant ArbosVersion_StylusChargingFixes

pulls in: OffchainLabs/go-ethereum#360

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 13, 2024
@tsahee tsahee added the ArbOS label Sep 13, 2024
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eljobe
eljobe previously approved these changes Sep 17, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -332,6 +331,9 @@ func (state *ArbosState) UpgradeArbosVersion(
ensure(params.UpgradeToVersion(2))
ensure(params.Save())

case 32:
// no change state needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to return an error if it's not a debug chain, otherwise out-of-date nodes will process the upgrade. We could just generally error if the version we're upgrading to is less than MaxArbosVersionSupported. That might be the way to go.

@tsahee tsahee dismissed stale reviews from eljobe and ganeshvanahalli via 8fd0ff4 September 20, 2024 02:55
@tsahee
Copy link
Contributor Author

tsahee commented Sep 26, 2024

merged in a different PR

@tsahee tsahee closed this Sep 26, 2024
@tsahee tsahee deleted the arbos_v32_debug branch September 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArbOS s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants