Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow create rollup callvalue override #194

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: allow create rollup callvalue override #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/createRollupPrepareTransactionRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export type CreateRollupPrepareTransactionRequestParams<TChain extends Chain | u
WithRollupCreatorAddressOverride<{
params: CreateRollupParams;
account: Address;
value?: bigint;
publicClient: PublicClient<Transport, TChain>;
gasOverrides?: TransactionRequestGasOverrides;
}>
Expand All @@ -40,6 +41,7 @@ export type CreateRollupPrepareTransactionRequestParams<TChain extends Chain | u
export async function createRollupPrepareTransactionRequest<TChain extends Chain | undefined>({
params,
account,
value,
publicClient,
gasOverrides,
rollupCreatorAddressOverride,
Expand Down Expand Up @@ -81,7 +83,7 @@ export async function createRollupPrepareTransactionRequest<TChain extends Chain
chain: publicClient.chain,
to: rollupCreatorAddressOverride ?? getRollupCreatorAddress(publicClient),
data: createRollupEncodeFunctionData([paramsWithDefaults]),
value: createRollupGetCallValue(paramsWithDefaults),
value: value ?? createRollupGetCallValue(paramsWithDefaults),
account,
// if the base gas limit override was provided, hardcode gas to 0 to skip estimation
// we'll set the actual value in the code below
Expand Down
Loading