This proposes to introduce a random number generator class #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… follow the state of the art for random number generation) and to change source code places that work with random numbers to use this class. Also deprecates older mechanisms. Places that don't actually require cryptographically-secure randomness are also changed, as they would otherwise appear as false positives in pentests. Related: https://php.watch/articles/testing-php-rand-functions https://github.com/matomo-org/matomo/pull/15263/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes to introduce a random number generator class which can follow the state of the art for random number generation) and to change source code places that work with random numbers to use this class. Also deprecates older mechanisms.
Currently only acts as a wrapper arround random_bytes() and random_int()
Places that don't actually require cryptographically-secure randomness are also changed, as they would otherwise appear as false positives in pentests.
Related:
https://php.watch/articles/testing-php-rand-functions
https://github.com/matomo-org/matomo/pull/15263/files