Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snyk reports on child CWEs for PathTraversal and password hashing (#90) #91

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Snyk reports on child CWEs for PathTraversal and password hashing (#90) #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/src/main/java/org/owasp/benchmarkutils/score/CweNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ public class CweNumber {
/** CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') */
public static int PATH_TRAVERSAL = 22;

/** CWE-23: Relative Path Traversal */
public static int RELATIVE_PATH_TRAVERSAL = 23;

/**
* CWE-78: Improper Neutralization of Special Elements used in an OS Command ('OS Command
* Injection')
Expand Down Expand Up @@ -166,6 +169,9 @@ public class CweNumber {
/** CWE-835: Loop with Unreachable Exit Condition ('Infinite Loop') */
public static int LOOP_WITH_UNREACHABLE_EXIT = 835;

/** CWE-916: Use of Password Hash With Insufficient Computational Effort */
public static int PASSWORD_HASH_WITH_INSUFFICIENT_COMPUTATIONAL_EFFORT = 916;

/** CWE-918: Server-Side Request Forgery (SSRF) */
public static int SSRF = 918;

Expand Down
15 changes: 15 additions & 0 deletions plugin/src/main/java/org/owasp/benchmarkutils/score/parsers/sarif/SnykReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,24 @@
*/
package org.owasp.benchmarkutils.score.parsers.sarif;

import org.owasp.benchmarkutils.score.CweNumber;

public class SnykReader extends SarifReader {

public SnykReader() {
super("SnykCode", true, CweSourceType.FIELD);
}

@Override
public int mapCwe(int cwe) {
if (cwe == CweNumber.PASSWORD_HASH_WITH_INSUFFICIENT_COMPUTATIONAL_EFFORT) {
return CweNumber.WEAK_HASH_ALGO;
}

if (cwe == CweNumber.RELATIVE_PATH_TRAVERSAL) {
return CweNumber.PATH_TRAVERSAL;
}

return super.mapCwe(cwe);
}
}
9 changes: 9 additions & 0 deletions plugin/src/test/java/org/owasp/benchmarkutils/score/parsers/sarif/SnykReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,13 @@ void readerHandlesGivenResultFile() throws Exception {
assertEquals(CweNumber.INSECURE_COOKIE, result.get(1).get(0).getCWE());
assertEquals(CweNumber.XPATH_INJECTION, result.get(2).get(0).getCWE());
}

@Test
void readerMapsCwes() {
SnykReader reader = new SnykReader();
assertEquals(
CweNumber.WEAK_HASH_ALGO,
reader.mapCwe(CweNumber.PASSWORD_HASH_WITH_INSUFFICIENT_COMPUTATIONAL_EFFORT));
assertEquals(CweNumber.PATH_TRAVERSAL, reader.mapCwe(CweNumber.RELATIVE_PATH_TRAVERSAL));
}
}