Snyk reports on child CWEs for PathTraversal and password hashing #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - thanks for the contribution, but the proper way to do this is to fix it in SnykReader, not in BenchmarkScore. Please move your fix to SnykReader. SnykReader extends SarifReader, which has a method called mapCwe() which you can override in SnykReader() to implement this mapping. |
davewichers
added a commit
that referenced
this pull request
Aug 15, 2024
… (#91) * Snyk reports on child CWEs for PathTraversal and password hashing * Move CWE mapping logic into SnykReader itself & add tests Looks good to me. Thanks for fixing. Co-authored-by: Sebastian Roth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
BenchmarkScoreto reflect Snyks behavior of reporting the specific child CWE instead of the expected parent CWE for both path traversal and weak hash CWEs.