feat: add support to iterator over encrypted zip #116
Conversation
Signed-off-by: Otavio Salvador <[email protected]>
There was a problem hiding this comment.
Thank you for the pull request! We appreciate your contribution to the project. However, we still have some items to look at before we can merge your code into the repository. I also wanted to let you know that I sent a small code rework to simplify the code. Thank you again for your help!
src/iterator.rs
Outdated
| @@ -44,6 +44,20 @@ pub enum ArchiveContents { | |||
| /// The entry is processed on a return value of `true` and ignored on `false`. | |||
| pub type EntryFilterCallbackFn = dyn Fn(&str, &libc::stat) -> bool; | |||
|
|
|||
| pub struct Password(Vec<u8>); | |||
There was a problem hiding this comment.
Needs documentation.
The type would be better named as ArchivePassword?
src/iterator.rs
Outdated
| @@ -265,11 +284,11 @@ impl<R: Read + Seek> ArchiveIterator<R> { | |||
| /// # Ok(()) | |||
| /// # } | |||
| /// ``` | |||
| pub fn from_read(source: R) -> Result<ArchiveIterator<R>> | |||
| pub fn from_read(source: R, password: Option<Password>) -> Result<ArchiveIterator<R>> | |||
There was a problem hiding this comment.
I'd like to have two methods:
from_read: same as beforefrom_read_with_password: new
|
Also, CI is failing but it works locally; any idea? |
Signed-off-by: Otavio Salvador <[email protected]>
|
I didn't understand either, I realized that when I run the "cargo test" it breaks in my test, but if I run my test individually it works, it's like I'm mocking some function I'm using.. And regarding the fixes, I'll try to do it tomorrow, all the points you commented make total sense. |
|
If it fails in your machine, it might be a race of memory corruption. Check in cargo-valgrind. |
Signed-off-by: Otavio Salvador <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
|
@hivexdev progress. The failing tests are fixed. The Windows failure is unrelated. |
|
@hivexdev have you looked at this? |
|
can the passphrase be non ascii , will this work for decrypting a password protectd zip? |
|
can non ascii password be used to decrypt a paswd protectd zip file |
Pull Request Test Coverage Report for Build 5148429169Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 5148429169Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Adding support to iterate over encrypted archives zip.
ONLY SUPPORTS ZIP ( libarchive limitation )
libarchive documentation -> readme.md
Note:
I just implemented it in the iterator, because I don't have time to implement it in the rest, but the idea is the same.
Support for (RAR)
It doesn't support encrypted '.rar' files, because it is a limitation of the libarchive itself, I searched in every way and even after implementing the correction I tried to iterate over a '.rar' file, but I don't get an error and it doesn't display any content either.
the only solution I saw that works is a binding made in unrar.c, but for that I would have to restructure the entire library to implement only this use case for '.rar' file