-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #78 Implementing Number Format Parser #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robons
commented
Dec 7, 2021
…alue of the number parsed.
…luding support for the pattern requiring an explicit sign char.
robons
changed the title
WIP - Issue #78 Implementing Number Format Parser
Issue #78 Implementing Number Format Parser
Dec 9, 2021
cjfairchild
suggested changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments for actionable issues - they're minor - one for error catching and likely compiler complaints and another for documentation around the ArrayCursor
class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets basic Unicode UTS-35/TR-35/UAX-35 number format validation functioning within the standards set out by unicode and the W3C CSV-W working group. Notably, all W3C CSV-W tests relating to number format validation now pass successfully.
N.B. It is not required that we implement the full UTS-35 specification. This PR does support the padding, rounding or significant digits functionality, however it is entirely possible to retrofit this functionality at a later point in time, if desired.
N.B. This approach parses all numbers to the
BigDecimal
infinite precision datatype. This isn't likely to be the most performant approach, but it is simple to convert the parsed value from a string into a numeric representation.Newly created issues: #98, #99
This PR satisfies #90.