Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to change the forcesave options with env variables #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppom0
Copy link

@ppom0 ppom0 commented Nov 10, 2022

I recently had a loss of data due to OnlyOffice not detecting end of editing sessions and not saving back documents.

I discovered the forcesave autoAssembly option, which is very valuable to me.
But I had trouble overriding local.json in a working manner:
If I mount it to the container, it gets overrode by the entrypoint, and if I mount it read-only, the entrypoint crashes.

So I patched the container entrypoint, to be able to configure those parameters as environment variables.

Tell me what you think about this PR and which changes you'd need to merge it.

Many thanks!

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paco seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ppom0 ppom0 force-pushed the permit-forcesave-as-env-var branch from 80602bf to 3589af4 Compare November 10, 2022 15:11
@thopico
Copy link

thopico commented Mar 13, 2023

Hello !
Thanks a lot @aopom for this PR, I faced similar issue and lost also lot of work...

Any idea when the dev team will have time to review this PR?
It is quite simple and would help many of us (thinking about issues nextcloud/documentserver_community#12 nextcloud/documentserver_community#77 nextcloud/documentserver_community#78 nextcloud/documentserver_community#87 nextcloud/documentserver_community#100)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants