feat(Search): Support pinyin search (#33) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renbaoshuo
requested changes
Sep 1, 2022
There was a problem hiding this comment.
感谢您的贡献。以下是一些改进建议：
- https://github.com/creeperyang/pinyin 不支持多音字，需要在 https://github.com/OIerDb-ng/OIerDb-data-generator 中特殊处理（可能需要维护一份作姓氏时与其他用途时读音不同的汉字的列表）；
- 建议与现有的拼音首字母查询功能做一个整合（现在生成的数据中已经包含了拼音首字母信息，可以考虑移动至前端处理以节省流量）；
- 人名中生僻字的转换准确度未知，需要另行测试；
- 按拼音搜索时建议按照匹配度返回结果。
src/components/Search.tsx
Outdated
| (oier) => | ||
| oier.name === input || | ||
| oier.initials === input || | ||
| (input && oier.pinyin.includes(input)) |
There was a problem hiding this comment.
考虑一种情况：
| # | 姓名 | 拼音 |
|---|---|---|
| 1 | 王五 | wangwu |
| 2 | 吴六 | wuliu |
此时大部分人的期望结果为「吴六」，但返回结果中「王五」会排在「吴六」之前。
Co-authored-by: Baoshuo Ren <[email protected]>
Co-authored-by: Baoshuo Ren <[email protected]>
Co-authored-by: Baoshuo Ren <[email protected]>
Co-authored-by: Baoshuo Ren <[email protected]>
Co-authored-by: Baoshuo Ren <[email protected]>
✅ Deploy Preview for oierdb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
生僻字和多音字(名)的中文字典比较大, 搞的话估计得手动维护一份仅满足所有选手的字典 拼音首字母和拼音功能确实重复, 首字母是在https://github.com/OIerDb-ng/OIerDb-data-generator生成的吗, 不懂python
|
renbaoshuo
force-pushed
the
master
branch
2 times, most recently
from
a923cbe
to
38224fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #33.