Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/608/70x/20241022/v1 #12005

Merged
merged 2 commits into from
Oct 22, 2024
Merged

next/608/70x/20241022/v1 #12005

merged 2 commits into from
Oct 22, 2024

Conversation

victorjulien
Copy link
Member

@zemeteri @jufajardini
detect: add new_de_ctx release in case of errors in initialization
1bf5550 
Detect engine tenant reloading function hasn't got engine release call
under error label, so it is possible memory leak in case of errors in
further new detect engine initialization.

Bug: OISF#7303
(cherry picked from commit adcac9e)
@zemeteri @victorjulien
conf: init parser after check with stat()
4f80cb5 
Commit changes are made to avoid possible memory leaks. If the parser
is initialized before configuration file checking, there was no deinit
call before function return. Do check config file existance and type
before YAML parser initialization, so we don't need to deinit parser
before exiting the function.

Bug: OISF#7302
(cherry picked from commit 87e6e93)
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.32%. Comparing base (8810d7f) to head (4f80cb5).
Report is 2 commits behind head on main-7.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x   #12005      +/-   ##
==============================================
+ Coverage       82.93%   83.32%   +0.39%     
==============================================
  Files             922      922              
  Lines          251298   260804    +9506     
==============================================
+ Hits           208418   217322    +8904     
- Misses          42880    43482     +602
Flag Coverage Δ
fuzzcorpus 64.64% <0.00%> (+0.54%) ⬆️
suricata-verify 63.28% <14.28%> (+0.43%) ⬆️
unittests 62.38% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23154

jufajardini
jufajardini approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Backport tickets exist ✅
  • Original PRs approved ✅
  • Number of commits and line changes match ✅

@victorjulien victorjulien merged commit 4f80cb5 into OISF:main-7.0.x Oct 22, 2024
45 checks passed
This was referenced Oct 22, 2024
Merged
Closed
@victorjulien victorjulien deleted the next/608/70x/20241022/v1 branch October 22, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jufajardini @zemeteri