Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function declarations-v4 #11998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nancyenos
Copy link

@Nancyenos Nancyenos commented Oct 21, 2024

Ticket: #7297

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297

Describe changes:
-Remove duplicate function declarations from header files
-Add a prefix misc: to the subject
-previous pr: #11993

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nancyenos !
The subject line change is to be done in the commit not the PR title. ;)

@Nancyenos Nancyenos changed the title misc: Remove duplicate function declarations Remove duplicate function declarations Oct 22, 2024
@Nancyenos Nancyenos force-pushed the Remove-duplicate-function-declarations-v-4 branch from 26f0fd8 to aa4523f Compare October 22, 2024 12:10
@Nancyenos Nancyenos changed the title Remove duplicate function declarations Remove duplicate function declarations-v4 Oct 22, 2024
@Nancyenos
Copy link
Author

@inashivb is it okay now?

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (55b922c) to head (aa4523f).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11998      +/-   ##
==========================================
+ Coverage   82.75%   83.23%   +0.48%     
==========================================
  Files         910      910              
  Lines      249016   258136    +9120     
==========================================
+ Hits       206069   214857    +8788     
- Misses      42947    43279     +332     
Flag Coverage Δ
fuzzcorpus 61.44% <ø> (+0.63%) ⬆️
livemode 19.38% <ø> (+0.67%) ⬆️
pcap 44.43% <ø> (+0.30%) ⬆️
suricata-verify 62.75% <ø> (+0.46%) ⬆️
unittests 59.29% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 22, 2024
@jufajardini
Copy link
Contributor

@inashivb is it okay now?

The commit message is good now, thanks (although we prefer not having PRs with force-pushes ;) )
The failing check, although not due to your PR, is probably something that we'll need to sort out, as the failure means those checks did not run on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants