Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL: parser v2 #11996

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

QianKaiLin
Copy link

@QianKaiLin QianKaiLin commented Oct 21, 2024

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

  • I have updated the User Guide (in doc/userguide/) to reflect the changes made
  • I have updated the JSON schema (in etc/schema.json) to reflect all logging changes
    (including schema descriptions)

Link to ticket: https://redmine.openinfosecfoundation.org/issues/3446

Describe changes:

  • fix mysql parser bug.
  • fix mysql logger bug.
  • add mysql detection keywords mysql.command and mysql.rows
  • add SV tests.
  • upgrade User Guide document and Upgrade document.

SV_BRANCH=OISF/suricata-verify#2067

Copy link

NOTE: This PR may contain new authors.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at all the CI failures, fix them and resubmit?
Thank you!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 4.48473% with 2002 lines in your changes missing coverage. Please review.

Project coverage is 67.14%. Comparing base (55b922c) to head (9bfc934).

❗ There is a different number of reports uploaded between BASE (55b922c) and HEAD (9bfc934). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (55b922c) HEAD (9bfc934)
suricata-verify 1 0
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11996       +/-   ##
===========================================
- Coverage   82.75%   67.14%   -15.61%     
===========================================
  Files         910      851       -59     
  Lines      249016   157138    -91878     
===========================================
- Hits       206069   105514   -100555     
- Misses      42947    51624     +8677     
Flag Coverage Δ
fuzzcorpus 60.62% <4.38%> (-0.19%) ⬇️
livemode 19.19% <4.48%> (+0.48%) ⬆️
pcap 43.88% <4.10%> (-0.25%) ⬇️
suricata-verify ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@QianKaiLin
Copy link
Author

Could you please take a look at all the CI failures, fix them and resubmit? Thank you!

Yeah, I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants