De cleanups/20241010/v4 #11959
Closed
De cleanups/20241010/v4 #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done following the fact that this setting was historically named incorrectly. The purpose of the setting was always to define the ports that will be prioritized and have rule groups associated w them on priority. Rename all occurences of this to correctly reflect the purpose of the setting.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11959 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 910 910
Lines 249008 249004 -4
=======================================
+ Hits 206038 206046 +8
+ Misses 42970 42958 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23104 |
victorjulien
approved these changes
Oct 15, 2024
catenacyber
reviewed
Oct 15, 2024
Merged
|
Merged in #11965, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #11957
Changes since v3: