Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform rust 7229 v4 #11927

Closed
wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7229

Describe changes:

  • transforms: move strip_whitespace and compress_whitespace and dot_prefix to rust

Should we do all transforms ?

#11926 without being a draft (better perf for other transforms)

Benchmark
./src/suricata -r bigf.pcapng -S bigf.rules -c bigf.yaml -k none -l log --runmode single
with big.rules being alert tcp any any -> any any (file.data; strip_whitespace; content:"hasxspace"; sid:1;) and bigf.pcapng being a capture of http1 download of 28 Mbyte file SV datasets-1m-StringSets/datasets.csv and bigf.yaml having all kinds of options for profiling

with PR

  Date: 10/10/2024 -- 11:10:46
  --------------------------------------------------------------------------------------------------------------------------------
  Stats for: total
  --------------------------------------------------------------------------------------------------------------------------------
  Prefilter                        Ticks           Called          Max Ticks       Avg             Bytes           Called          Max Bytes       Avg Bytes       Ticks/Byte     
  -------------------------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- 
  file_data#179 (strip_whitespace  77389980        119             2075940         650335.00       28534678        116             266949          245988.00       2.00      

With master

  Stats for: total
  --------------------------------------------------------------------------------------------------------------------------------
  Prefilter                        Ticks           Called          Max Ticks       Avg             Bytes           Called          Max Bytes       Avg Bytes       Ticks/Byte     
  -------------------------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- 
  file_data#179 (strip_whitespace  81533120        119             1905360         685152.00       28499770        116             266647          245687.00       2.00           

So 77389980 vs 81533120 does not seem significant for a difference

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 94.71545% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (d5dd549) to head (f93f479).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11927      +/-   ##
==========================================
- Coverage   82.70%   79.20%   -3.51%     
==========================================
  Files         912      912              
  Lines      249102   248904     -198     
==========================================
- Hits       206018   197134    -8884     
- Misses      43084    51770    +8686     
Flag Coverage Δ
fuzzcorpus 60.73% <91.66%> (+0.05%) ⬆️
livemode 18.72% <32.22%> (+<0.01%) ⬆️
pcap 44.11% <49.44%> (+<0.01%) ⬆️
suricata-verify ?
unittests 58.96% <66.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23076

@catenacyber
Copy link
Contributor Author

Rebased in #11934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants