threads: helper function TmThreadsWaitForUnpause #11923
Conversation
The pattern of checking the pause flag, setting to paused then waiting to unpause was done enough times to factor out into its own function. This is also needed by library users who bring their own packet acquisition threads.
| void TmThreadsWaitForUnpause(ThreadVars *tv) | ||
| { | ||
| if (TmThreadsCheckFlag(tv, THV_PAUSE)) { | ||
| TmThreadsSetFlag(tv, THV_PAUSED); | ||
| TmThreadTestThreadUnPaused(tv); | ||
| TmThreadsUnsetFlag(tv, THV_PAUSED); | ||
| } | ||
| } |
There was a problem hiding this comment.
As this is now the only user of TmThreadTestThreadUnPaused, perhaps they should just be merged and this could be the new TmThreadTestThreadUnPaused - however, I feel the "Wait" in the name is more descriptive than Test, as TmThreadTestThreadUnPaused does wait as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11923 +/- ##
==========================================
- Coverage 82.70% 78.35% -4.36%
==========================================
Files 912 912
Lines 249102 248905 -197
==========================================
- Hits 206018 195019 -10999
- Misses 43084 53886 +10802
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23072 |
| TmThreadTestThreadUnPaused(tv); | ||
| TmThreadsUnsetFlag(tv, THV_PAUSED); | ||
| } | ||
| TmThreadsWaitForUnpause(tv); |
There was a problem hiding this comment.
kind of wondering if we even pause a thread... other than it starting paused? If not, this could move out of the while loop? I know this stuff used to be a lot more complex in the past due to ideas about thread restarts and such.
There was a problem hiding this comment.
No, I think I looked at they only start paused. So this is only done for some startup synchronization and never again, so things can be simplified further here I think.
|
Replaced by #11943. |
The pattern of checking the pause flag, setting to paused then
waiting to unpause was done enough times to factor out into its own
function. This is also needed by library users who bring their own
packet acquisition threads.