TEST cache netmap github checkout #11914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
force-pushed
the
gh-cache-netmap/v1
branch
from
b81f369
to
f7f5c8b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11914 +/- ##
==========================================
- Coverage 82.70% 79.19% -3.51%
==========================================
Files 912 912
Lines 249102 248925 -177
==========================================
- Hits 206018 197139 -8879
- Misses 43084 51786 +8702
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
force-pushed
the
gh-cache-netmap/v1
branch
3 times, most recently
from
62ed863
to
73d1b51
Compare
To avoid build failures due to rate limiting, cache the netmap checkout. Explicitly restore and save to avoid the checkout action cleaning the checkout up before it can be stored in the cache.
victorjulien
force-pushed
the
gh-cache-netmap/v1
branch
from
73d1b51
to
3acf298
Compare
catenacyber
reviewed
Oct 9, 2024
| uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 | ||
| with: | ||
| repository: luigirizzo/netmap | ||
| # gets cloned to $GITHUB_WORKSPACE/netmap/ | ||
| path: netmap/ | ||
|
|
||
| - name: Save Netmap Cache |
There was a problem hiding this comment.
You could also cache the compilation
There was a problem hiding this comment.
I don't want to add additional complexity, this is just about avoiding the rate limit issue
catenacyber
reviewed
Oct 9, 2024
| @@ -2489,12 +2496,20 @@ jobs: | |||
| linux-headers-$(uname -r) | |||
|
|
|||
| - name: Checkout Netmap repository | |||
| if: steps.netmap-cache.outputs.cache-hit != 'true' | |||
| uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 | |||
There was a problem hiding this comment.
git clone seems to work better than actions/checkout in #11903
But not sure it is a good path to follow
There was a problem hiding this comment.
I think the checkout action is more idiomatic
Closed
|
replaced by #11918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.