Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating unittests in src/app-layer-htp.c to new FAIL/PASS API/v1 #11907

Conversation

Nancyenos
Copy link

Ticket: #6935

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6935

Describe changes:
-updated HTPParserTest01a to new FAIL/PASS API in src/app-layer-htp.c

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (501f79c) to head (fd7b1e9).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11907      +/-   ##
==========================================
+ Coverage   82.56%   82.61%   +0.04%     
==========================================
  Files         912      912              
  Lines      249354   249327      -27     
==========================================
+ Hits       205880   205971      +91     
+ Misses      43474    43356     -118     
Flag Coverage Δ
fuzzcorpus 60.68% <ø> (+0.21%) ⬆️
livemode 18.72% <ø> (-0.01%) ⬇️
pcap 44.09% <ø> (-0.01%) ⬇️
suricata-verify 62.02% <ø> (+0.02%) ⬆️
unittests 58.93% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Nancyenos Nancyenos closed this Oct 8, 2024
@Nancyenos Nancyenos deleted the convert-unittests-to-new-fail-pass-api-v1 branch October 8, 2024 18:43
@Nancyenos Nancyenos restored the convert-unittests-to-new-fail-pass-api-v1 branch October 8, 2024 18:43
@Nancyenos Nancyenos deleted the convert-unittests-to-new-fail-pass-api-v1 branch October 8, 2024 18:43
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

2 participants