Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/address: convert ipv4 unittests to FAIL/PASS - v3 #11881

Conversation

AkakiAlice
Copy link
Contributor

Ticket: #6318

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6318

Describe changes:

  • Update detect-engine-address-ipv4.c unittests to use FAIL/PASS API

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Previous PR: #11874

@AkakiAlice AkakiAlice changed the title detect/address: convert ipv4 unittests to FAIL/PASS detect/address: convert ipv4 unittests to FAIL/PASS - v3 Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (45eb7e4) to head (bde22fb).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11881      +/-   ##
==========================================
+ Coverage   82.60%   82.69%   +0.09%     
==========================================
  Files         912      912              
  Lines      249351   249110     -241     
==========================================
+ Hits       205965   206007      +42     
+ Misses      43386    43103     -283     
Flag Coverage Δ
fuzzcorpus 60.63% <ø> (+0.03%) ⬆️
livemode 18.72% <ø> (-0.01%) ⬇️
pcap 44.09% <ø> (+0.03%) ⬆️
suricata-verify 62.02% <ø> (-0.02%) ⬇️
unittests 58.99% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big file. Thanks! :)
LGTM 🚀

@victorjulien victorjulien added this to the 8.0 milestone Oct 8, 2024
@victorjulien
Copy link
Member

Merged in #11905, thanks!

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

4 participants