detect-engine-address-ipv4: convert unittests to FAIL/PASS APIs

[AkakiAlice]

Ticket #6318

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

• I have read the contributing guide lines at
  https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

• I have signed the Open Information Security Foundation contribution agreement at
  https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

• I have updated the User Guide (in doc/userguide/) to reflect the changes made
• I have updated the JSON schema (in etc/schema.json) to reflect all logging changes
  (including schema descriptions)
• I have created a ticket at
  https://redmine.openinfosecfoundation.org/projects/suricata/issues

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6318

Describe changes:

• Update detect-engine-address-ipv4.c unittests to use FAIL/PASS API

Provide values to any of the below to override the defaults.

• To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
  link to the pull request in the respective _BRANCH variable.
• Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (45eb7e4) to head (9a6a793).
Report is 12 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11873      +/-   ##
==========================================
- Coverage   82.60%   82.57%   -0.03%     
==========================================
  Files         912      912              
  Lines      249351   249347       -4     
==========================================
- Hits       205965   205908      -57     
- Misses      43386    43439      +53     

Flag	Coverage Δ
fuzzcorpus	60.46% <ø> (-0.14%)	⬇️
livemode	18.72% <ø> (-0.01%)	⬇️
pcap	44.08% <ø> (+0.01%)	⬆️
suricata-verify	62.02% <ø> (-0.02%)	⬇️
unittests	58.94% <70.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jufajardini]

Hi there, we're on the right path, but some more work to be done, to be fully compliant with the work required for this FAIL/PASS API conversion.

Please read my inline comment, I think it will help with all other cases present here, too. The parent ticket for this task my offer more insight and background into this work, if you want: https://redmine.openinfosecfoundation.org/issues/2975

For the commit message title, it's too long, you could shorten it, while still preserving meaning, like so:
detect/address: convert ipv4 unittests to FAIL/PASS

[jufajardini]

Basically, all the lines that do something and then use a goto error are a FAIL case, and should be converted to a FAIL_IF format.

One of the goals for the FAIL/PASS API conversion is to remove all branching logic (the if checks) in unit tests, too.

So let's try to clean up this test (and others in this file if they follow a similar patter), so that we first have all FAIL possibilities, and, if nothing has failed, we will then have the calls to Free functions, to avoid memory leaks on PASS, and finish the test with a PASS.

This will further improve readability, and also allow us to get rid of the result variable, since we will be explicitly failing for each check case.

[AkakiAlice]

Ok, thank you so much for clarifying! I was feared it could cause unwanted memory leaks by not freeing the variables in case the test fails, I don't need to worry with that?

[jufajardini]

Indeed, we only have to avoid memory leaks in the PASS scenario :)