7303 fix new_de_ctx disposal in case of error #11868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemeteri
force-pushed
the
7303-fix-mem-leak-detect-engine
branch
from
05a0620
to
b12a53d
Compare
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11868 +/- ##
==========================================
+ Coverage 82.56% 82.61% +0.04%
==========================================
Files 912 912
Lines 249354 249356 +2
==========================================
+ Hits 205880 205998 +118
+ Misses 43474 43358 -116
Flags with carried forward coverage won't be shown. Click here to find out more. |
Detect engine tenant reloading function hasn't got engine release call under error label, so it is possible memory leak in case of errors in further new detect engine initialization. Bug: OISF#7303
zemeteri
force-pushed
the
7303-fix-mem-leak-detect-engine
branch
from
b12a53d
to
5ff03ce
Compare
|
NOTE: This PR may contain new authors. |
victorjulien
approved these changes
Oct 8, 2024
Merged
|
Merged in #11905, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7303
Describe changes: