7302 init parser after check with stat() #11867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemeteri
force-pushed
the
7302-fix-mem-leak-conf-parser
branch
from
5cebe8c
to
508e183
Compare
jufajardini
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Hi, thanks for reporting this and sharing a possible patch.
Could you please add a brief explanation in the commit message body about why was it necessary? It help even when reviewing, if the issue isn't immediately apparent to the reviewer :)
We will also need a couple of adjusts to the commit, before patches can be merged:
- adjust the commit message following our guidelines
- adjust the author name to be in human readable format? :P We use the
FirstName LastNameformat
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11867 +/- ##
==========================================
- Coverage 82.56% 77.69% -4.87%
==========================================
Files 912 912
Lines 249354 249329 -25
==========================================
- Hits 205880 193724 -12156
- Misses 43474 55605 +12131
Flags with carried forward coverage won't be shown. Click here to find out more. |
zemeteri
force-pushed
the
7302-fix-mem-leak-conf-parser
branch
from
508e183
to
2cca563
Compare
|
Hi, Juliana
Thanks for notifying me, I updated PRs.
Sincerely Yours,
Zemeteri.
…On Thu, Oct 3, 2024 at 6:54 PM Juliana Fajardini Reichow < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi, thanks for reporting this and sharing a possible patch.
Could you please add a brief explanation in the commit message body about
why was it necessary? It help even when reviewing, if the issue isn't
immediately apparent to the reviewer :)
We will also need a couple of adjusts to the commit, before patches can be
merged:
- adjust the commit message following our guidelines
<https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#commits>
- adjust the author name to be in human readable format? :P We use the FirstName
LastName format
—
Reply to this email directly, view it on GitHub
<#11867 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS4GLIL2I5YQ5IPOVQ7LL7DZZVSFHAVCNFSM6AAAAABPJNYPHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBWGAZDAOBRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
NOTE: This PR may contain new authors. |
victorjulien
approved these changes
Oct 8, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
zemeteri
force-pushed
the
7302-fix-mem-leak-conf-parser
branch
from
2cca563
to
381334f
Compare
|
Please open a new PR when implementing changes. |
|
Hi Victor,
I closed previous PR and just opened new, rebasing my branch to latest
master. However I see a lot of CI fails. What should I do now?
Sincerely Yours,
Zemeteri.
…On Tue, Oct 8, 2024 at 2:01 PM Victor Julien ***@***.***> wrote:
Please open a new PR when implementing changes.
—
Reply to this email directly, view it on GitHub
<#11867 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS4GLINS3ZCO3AC65LE3MCTZ2O3RBAVCNFSM6AAAAABPJNYPHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGUZTGMBVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7302
Describe changes: