Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx track modif 7087 v12 #11818

Closed
wants to merge 2 commits into from
Closed

Tx track modif 7087 v12 #11818

wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7087

Describe changes:

  • app-layer: track modified/processed txs

#11781 with needed rebase

@catenacyber
app-layer: track modified/processed txs
2f3c5be 
To optimize detection, and logging, to avoid going through
all the live transactions when only a few were modified.

Ticket: 7087
@catenacyber
rust/ftp: handle NULL inputs
e588bc4 
Completes Ticket 7013
@catenacyber catenacyber mentioned this pull request Sep 23, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (7ab8334) to head (e588bc4).
Report is 33 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11818      +/-   ##
==========================================
+ Coverage   82.58%   82.60%   +0.01%     
==========================================
  Files         914      914              
  Lines      249500   249596      +96     
==========================================
+ Hits       206045   206174     +129     
+ Misses      43455    43422      -33
Flag Coverage Δ
fuzzcorpus 60.59% <91.58%> (+0.16%) ⬆️
livemode 18.86% <0.00%> (+0.13%) ⬆️
pcap 44.10% <72.89%> (+0.03%) ⬆️
suricata-verify 62.05% <83.17%> (+0.03%) ⬆️
unittests 58.96% <45.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 649 624 96.15%

Pipeline 22811

@jufajardini
Copy link
Contributor

jufajardini commented Oct 3, 2024 •
edited
Loading

Does this baseline difference works as a sort of test that we're going in the right direction? (This comes from em trying to understand how could this be tested)

@catenacyber
Copy link
Contributor Author

Does this baseline difference works as a sort of test that we're going in the right direction? (This comes from em trying to understand how could this be tested)

Not sure it should show a meaningful difference

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 649 624 96.15%

Pipeline 22965

@victorjulien
Copy link
Member

We're seeing a similar deviation throughout runs in the last 2 weeks.

@catenacyber catenacyber mentioned this pull request Oct 8, 2024
Closed
@catenacyber
Copy link
Contributor Author

Next in #11912

@catenacyber catenacyber closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien left review comments

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catenacyber @suricata-qa @jufajardini @victorjulien