tls: assorted checks - v1 #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this was missing from the logs, ensure that there won't be any regressions. Related to Bug #7332
jufajardini
commented
Oct 17, 2024
| packet: no | ||
| metadata: no | ||
| - tls: | ||
| custom: [subject, issuer, serial, fingerprint, sni, version, not_before, not_after, subjectaltname] |
There was a problem hiding this comment.
added this to ensure that we're logging subjectaltname using the custom logging function.
victorjulien
approved these changes
Oct 17, 2024
|
Merged in #2099, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for TLS missing fields from JSON schema or from the output (
subjectaltnamewas missing from logs,certificateandchainwere missing from the schema)Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: