Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NZSL-164: Show the database version in the footer #1525

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

joshmcarthur
Copy link
Contributor

@joshmcarthur joshmcarthur commented Jan 11, 2024

This pull request adds the database version to the website footer as implemented by ackama/nzsl-share#604.

I've moved the footer template ivars around a little, since the purpose of the @footer page is to provide a NZSL translation of the copyright info, which I think we should always show regardless of whether there is a translation available or not.

image

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

app/views/shared/_footer.html.erb Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@joshmcarthur joshmcarthur merged commit b5f9c74 into main Jan 15, 2024
6 checks passed
@joshmcarthur joshmcarthur deleted the task/nzsl-164-show-database-version branch January 15, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants