NZSL-159: Update dictionary from S3 rather than a github release #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the boot process of the NZSL Dictionary to download a file from a specified S3 location. This can be a public or private S3 object, and the URI is specified using an environment variable. We attempt to download from the public location first, then attempt to generate a presigned URL and download from that. If no keypair is present and the public URL is not accessible (e.g. this is a prerelease database), then the app continues to boot, but without a dictionary database.
The Github releases continue to be available for app use, however using a file pushed to S3 allows us to handle data previews and a faster release cycle when checking signs prior to public release.