Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][REF] hr_timesheet_activity_begin_end: Make more extensible #693

Open
wants to merge 2 commits into
base: 12.0
Choose a base branch
from
Open

[12.0][REF] hr_timesheet_activity_begin_end: Make more extensible #693

wants to merge 2 commits into from

Commits on Jun 28, 2024

  1. [FIX] hr_timesheet_begin_end: Test uses timesheet lines now 

    Timesheet lines are characterised by having a project.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c5931f9 View commit details
    Browse the repository at this point in the history

  2. [REF] hr_timesheet_activity_begin_end: Make more extensible 

    The separation of checks into separate methods is needed because I want
to disable one check in another module. This makes the module more
extensible.

The unit_amount_from_start_stop method also makes the module more
extensible.

I have also moved the onchange to the top of the file, according to the
OCA contribution guidelines.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    14c76a7 View commit details
    Browse the repository at this point in the history