Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] model_serializer: module to facilitate the (de)serialization of Odoo Models into DataModels #193

Merged
merged 1 commit into from
Nov 9, 2021
Merged

[14.0][ADD] model_serializer: module to facilitate the (de)serialization of Odoo Models into DataModels #193

merged 1 commit into from
Nov 9, 2021

Conversation

fdegrave
Copy link

@fdegrave fdegrave commented Sep 2, 2021

Forward port of PR #177

[14.0][ADD] model_serializer: module to facilitate the (de)serializat…
c42b269 
…ion of Odoo Models into DataModels

Forward port of PR OCA#177
@OCA-git-bot
Copy link
Contributor

Hi @fdegrave! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

lmignon
lmignon reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdegrave GREAT! Looks very interesting. LGTM (code review only)

@lmignon
Copy link
Contributor

lmignon commented Nov 9, 2021

I'll proceed to the merge since this PR is for a long time ready. Thank you for your contribution. You could be interested by #218 (More powerfull, easier to use, and pythonic)

@lmignon
Copy link
Contributor

lmignon commented Nov 9, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-193-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2021
@OCA-git-bot
Merge PR #193 into 14.0
6615c3f 
Signed-off-by lmignon
@lmignon lmignon mentioned this pull request Nov 9, 2021
Merged
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-193-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7feed7c into OCA:14.0 Nov 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 30da45c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon left review comments

Assignees
No one assigned
Labels
14.0 merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fdegrave @OCA-git-bot @lmignon