-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] purchase_last_price_info: Migration to 18.0 #2439
Open
StefanRijnhart
wants to merge
51
commits into
OCA:18.0
Choose a base branch
from
StefanRijnhart:18.0-mig-purchase_last_price_info
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] purchase_last_price_info: Migration to 18.0 #2439
StefanRijnhart
wants to merge
51
commits into
OCA:18.0
from
StefanRijnhart:18.0-mig-purchase_last_price_info
+3,339
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] <purchase_last_price_info> Deleted dependency [IMP] <purchase_last_price> Changed to avoid initializing to False [IMP] <purchase_last_price_info> Minor changes [IMP] <purchase_last_price_info> added test [IMP] <purchase_last_price_info> OCA required _id added [FIX] <purchase_last_price_info> test fixed [IMP] Update <purchase_last_price_info> New version format and Try me button [IMP] <purchase_last_price_info> Test updated data when purchase.order is confirmed
[ADD] post-init hook [ADD] migration script
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-11.0/purchase-workflow-11.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-11-0/purchase-workflow-11-0-purchase_last_price_info/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_last_price_info/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_last_price_info/zh_CN/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_last_price_info/es/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_last_price_info/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_last_price_info/zh_CN/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_last_price_info/de/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_last_price_info/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_last_price_info/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_last_price_info/fr_FR/
…urchase_price_currency in products. Refactor code: Now used last_purchase_line_id field and is auto-set wit all info. When adding new purchase order lines last_purchase_line_ids field will be used to re-compute last_purchase_line_id field and change all information. TT30742
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_last_price_info/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/
Currently translated at 100.0% (14 of 14 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/hr/
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/pt_BR/
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/
…ency Depending on the installed modules, the company currency may be USD or EUR, affecting the result of these tests. With this PR, the results are adjusted for both cases.
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_last_price_info Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_last_price_info/it/
On purchase.order.line creation, `_update_inverses` is called before the value of purchase.order.line.company_id is computed. `_update_inverses` causes Odoo to filter purchase.order.line to find the correct lines to put into the cache, which in turn causes access rights check. And because company_id is not yet computed it fails. Fixing by removing domain from `last_purchase_line_ids` to avoid filtering and filter it later manually.
StefanRijnhart
force-pushed
the
18.0-mig-purchase_last_price_info
branch
from
October 17, 2024 16:39
7e39505
to
07d0000
Compare
/ocabot migration purchase_last_price_info |
StefanRijnhart
changed the title
[18.0][MIG] purchase_last_price_info
[18.0][MIG] purchase_last_price_info: Migration to 18.0
Oct 17, 2024
CasVissers-360ERP
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.