[16.0] [FIX] purchase_request: Invalid Operator - Typo "=?" change to "=" #2435
Conversation
Operator Updated
|
@lekha-sydney-tools from our team has come across this operator typo in the code which results in an 'operation not supported' error when trying to trigger the Create RFQ button in the Create RFQ wizard as shown (apologies for the messy screenshot): 
If anyone is available to give this a quick review to get this typo fix merged? It would be great to get this fixed upstream here so we can get rid of our local copy of this fix and just pull the latest from this repo. |
lekha-sydney-tools
changed the title
| @@ -199,7 +199,7 @@ def _get_order_line_search_domain(self, order, item): | |||
| ("name", "=", name), | |||
| ("product_id", "=", item.product_id.id), | |||
| ("product_uom", "=", vals["product_uom"]), | |||
| ("analytic_distribution", "=?", item.line_id.analytic_distribution), | |||
| ("analytic_distribution", "=", item.line_id.analytic_distribution), | |||
There was a problem hiding this comment.
It is not a typo. =? is a valid operator: https://github.com/odoo/odoo/blob/16.0/odoo/osv/expression.py#L1120-L1122
But the analytic distribution is a tricky field, and I assume the operator may well be buggy in this case. To emulate the behaviour of the operator, you need to include this clause in the domain optionally (i.e. if item.line_id.analytic_distribution has any content).
And as always in case of a bugfix, please try and reproduce the bug in a test.
[16.0] [FIX] purchase_request: Invalid Operator - Typo "=?" change to "="