[18.0][MIG] purchase_request: Migration to 18.0 #2433
Conversation
* Move yml into python test * Pep8/Flake8
Currently translated at 100.0% (229 of 229 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
Currently translated at 100.0% (229 of 229 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
Currently translated at 100.0% (229 of 229 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
Currently translated at 100.0% (229 of 229 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/
Currently translated at 100.0% (228 of 228 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
Currently translated at 100.0% (228 of 228 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
Currently translated at 100.0% (228 of 228 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_request Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_request/it/
quoc-pn
force-pushed
the
18.0-mig-purchase_request
branch
2 times, most recently
from
080e345
to
e952f7e
Compare
quoc-pn
force-pushed
the
18.0-mig-purchase_request
branch
from
e952f7e
to
eb5b8f1
Compare
|
@quoc-pn Tests still fail. You could try running them locally to see if all is well before you push. There is also a markup warning. I solved a similar warning in https://github.com/OCA/purchase-workflow/pull/2382/files that you could apply here as well. |
quoc-pn
force-pushed
the
18.0-mig-purchase_request
branch
from
eb5b8f1
to
cf21b43
Compare
quoc-pn
force-pushed
the
18.0-mig-purchase_request
branch
from
cf21b43
to
8cfffce
Compare
| @@ -104,7 +104,6 @@ def test_procure_purchase_request(self): | |||
| self.env["mail.activity"].search( | |||
| [("activity_type_id", "=", activity.id)] | |||
| ).unlink() | |||
| activity.unlink() | |||
There was a problem hiding this comment.
The comments above these lines say 'An activity is created on the request even if the activity type was deleted'. If we don't delete the activity type anymore, we don't test the original requirement. Did this functionality break?
There was a problem hiding this comment.
This error will be raised when unlinking the activity type.
@api.ondelete(at_uninstall=False)
def _unlink_except_todo(self):
if self.env.ref('mail.mail_activity_data_todo') in self:
raise UserError(_("The 'To-Do' activity type is used to create reminders from the top bar menu and the command palette. Consequently, it cannot be archived or deleted."))
odoo/addons/mail/models/mail_activity_type.py
There was a problem hiding this comment.
That is great! That means that the activity type is guaranteed to exist. We can then drop the safeguarding from https://github.com/OCA/purchase-workflow/pull/2433/files#diff-556ada671b2bd79c2398ed16f2f6ad66bc3720e47b87d1ca4c232a367e72a122R44-R47. Can you also remove or adjust the lines of this test that are about the situation in which this particular activity type is not found?
| if item.line_id.analytic_distribution: | ||
| analytic_account_ids = list(item.line_id.analytic_distribution.keys()) | ||
| order_line_data.append( | ||
| ("analytic_distribution", "in", analytic_account_ids) |
There was a problem hiding this comment.
I think matching the exact distribution, not just overlapping accounts is required.
| ("analytic_distribution", "in", analytic_account_ids) | ||
| ) | ||
| else: | ||
| order_line_data.append(("analytic_distribution", "=", False)) |
There was a problem hiding this comment.
The =? operator evaluates as True if the right hand side is falsy. That means that a request line without analytics can be linked to any order line with or without analytics. Did you mean to change that behaviour?
There was a problem hiding this comment.
The =? operator doesn't support when searching the field analytic_distribution anymore.
def _condition_to_sql(self, alias: str, fname: str, operator: str, value, query: Query) -> SQL:
if fname != 'analytic_distribution' or self.env.context.get('account_report_analytic_groupby'):
return super()._condition_to_sql(alias, fname, operator, value, query)
if operator not in ('=', '!=', 'ilike', 'not ilike', 'in', 'not in'):
raise UserError(_('Operation not supported'))
odoo/addons/analytic/models/analytic_mixin.py
There was a problem hiding this comment.
Yes indeed! Do you agree that we should still keep the original behaviour, which means ignoring the analytics of existing purchase lines in case of a request line that has no analytics set?
No description provided.