Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] pos_picking_delayed #1227

Merged
merged 30 commits into from
Oct 9, 2024
Merged

[16.0][MIG] pos_picking_delayed #1227

merged 30 commits into from
Oct 9, 2024

Conversation

em230418
Copy link
Contributor

Commits are from this PR #1213

@legalsylvain legalsylvain added this to the 16.0 milestone Jul 24, 2024
legalsylvain
legalsylvain approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, @em230418 !

Diff review, LGTM !

/ocabot migration pos_picking_delayed

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 24, 2024
Open
37 tasks
@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1227-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 18, 2024
@OCA-git-bot
Merge PR #1227 into 16.0
cea60a3 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1227-by-ivantodorovich-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force em230418 tmp-pr-1227:16.0-mig-pos-picking-delayed failed with output:

To https://github.com/em230418/pos
 ! [remote rejected]   tmp-pr-1227 -> 16.0-mig-pos-picking-delayed (permission denied)
error: failed to push some refs to 'https://github.com/em230418/pos'

@em230418
Copy link
Contributor Author

Just added tick on "Allow edits by maintainers" in this PR. Probably it is the reason why it says "permission denined"

@legalsylvain
Copy link
Contributor

/ocabot rebase

legalsylvain and others added 13 commits October 9, 2024 21:22
@legalsylvain @OCA-git-bot
[ADD] new module pos_picking_delayed
61c705b 
- creating pos.order doesn't create picking, when it is created via create_from_ui;
- add a cron to generate picking of pos.order
- log when cron is called
- configuration in pos.config (picking_creation_delayed)
- handle correctly pos order that doesn't generate pickings. (based on services)
@legalsylvain @OCA-git-bot
[MIG][12.0] pos_picking_delayed
432d4db 
[IMP] replace cron by queue_job
@legalsylvain @OCA-git-bot
[FIX] revision
24479c5
@legalsylvain @OCA-git-bot
[IMP] Add default channel
aa9960d
@legalsylvain @OCA-git-bot
[FIX] disable feature for pos config demo, to avoid errors on other m…
5484085 
…odules of the same repository ; [IMP] improve the display of the field on the pos config form
@oca-travis @OCA-git-bot
[UPD] Update pos_picking_delayed.pot
b706b0b
@oca-transbot @OCA-git-bot
Update translation files
5d5748e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_picking_delayed
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_picking_delayed/
@danimv5 @OCA-git-bot
Added translation using Weblate (Spanish)
f7ff15b
@danimv5 @OCA-git-bot
Translated using Weblate (Spanish)
d6a31b3 
Currently translated at 100.0% (7 of 7 strings)

Translation: pos-12.0/pos-12.0-pos_picking_delayed
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_picking_delayed/es/
@legalsylvain @OCA-git-bot
[FIX] pos_picking_delayed: include demo data
f4dd30e
@CarlosRoca13 @OCA-git-bot
[IMP] pos_picking_delayed: Configuring pricelist on test
5601260
@legalsylvain @OCA-git-bot
[12.0][REF] pos_picking_delayed : refactor module, due to queue_job r…
7e12a05 
…efactoring. + Add idempotent test
@legalsylvain @OCA-git-bot
[FIX] configure.rst file (flake8 / lint)
e7d4928
legalsylvain and others added 17 commits October 9, 2024 21:22
@legalsylvain @OCA-git-bot
[REF] adopt several modules
421aecc
@CarlosRoca13 @OCA-git-bot
[IMP] pos_picking_delayed: black, isort, prettier
db04793
@CarlosRoca13 @OCA-git-bot
[MIG] pos_picking_delayed: Migration to 13.0
b40dd06
@oca-travis @OCA-git-bot
[UPD] Update pos_picking_delayed.pot
c57ee2b
@OCA-git-bot
[UPD] README.rst
1eac127
@oca-transbot @OCA-git-bot
Update translation files
707ccc5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-13.0/pos-13.0-pos_picking_delayed
Translate-URL: https://translation.odoo-community.org/projects/pos-13-0/pos-13-0-pos_picking_delayed/
@ivantodorovich @OCA-git-bot
[UPD] Use copier template and Github Actions
3f147be
@OCA-git-bot
pos_picking_delayed 13.0.1.0.1
e411431
@mymage @OCA-git-bot
Added translation using Weblate (Italian)
bce91f0
@mymage @OCA-git-bot
Translated using Weblate (Italian)
f2669a4 
Currently translated at 100.0% (7 of 7 strings)

Translation: pos-13.0/pos-13.0-pos_picking_delayed
Translate-URL: https://translation.odoo-community.org/projects/pos-13-0/pos-13-0-pos_picking_delayed/it/
@mymage @OCA-git-bot
Translated using Weblate (Italian)
2f4f32c 
Currently translated at 100.0% (7 of 7 strings)

Translation: pos-13.0/pos-13.0-pos_picking_delayed
Translate-URL: https://translation.odoo-community.org/projects/pos-13-0/pos-13-0-pos_picking_delayed/it/
@OCA-git-bot
[UPD] README.rst
22d3cfc
@em230418 @OCA-git-bot
[IMP] pos_picking_delayed: black, isort, prettier
416d804
@em230418 @OCA-git-bot
[MIG] pos_picking_delayed: Migration to 14.0
5c6a0b0
@em230418 @OCA-git-bot
[IMP] pos_picking_delayed: allow do override delayed picking job sett…
31c48d9 
…ings
@em230418 @OCA-git-bot
[IMP] pos_picking_delayed: black, isort, prettier
bcd0546
@em230418 @OCA-git-bot
[MIG] pos_picking_delayed: Migration to 16.0
33d33c0
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1227-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d2d59ee into OCA:16.0 Oct 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7550d7e. Thanks a lot for contributing to OCA. ❤️

@em230418 em230418 deleted the 16.0-mig-pos-picking-delayed branch October 10, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@em230418 @ivantodorovich @OCA-git-bot @legalsylvain @oca-travis @oca-transbot @danimv5 @CarlosRoca13 @mymage