Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][16.0] imp payroll account group entries #145

Draft
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

cvinh
Copy link

@cvinh cvinh commented Feb 15, 2024

In some country (ie FR or PF), the experts do not want to have separate account moves for payslips.
They want to have a global account move without the employees salary details
@Ana0m

@OCA-git-bot
Copy link
Contributor

Hi @nimarosa, @appstogrow,
some modules you are maintaining are being modified, check this out!

@cvinh cvinh force-pushed the 16.0-imp-payroll_account_group_entries branch from 738a851 to 560edf1 Compare February 15, 2024 22:41
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@nimarosa
Copy link
Contributor

Hello are you going to finish this PR? Tell me so I remove the stale tag.

@cvinh
Copy link
Author

cvinh commented Jun 18, 2024

Hello are you going to finish this PR? Tell me so I remove the stale tag.

Yes, please remove stale tag

@nimarosa nimarosa removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2024
@hitrosol
Copy link

I think grouping the journal entries can be made if the payslip_run_id is True by creating the payslip batch. And the journal entries will be created if all the payslip have been confirmed by user.
By this case, we don't have to create field action_group_payslips. We are going to create PR for this case in V14 soon.

@cvinh
Copy link
Author

cvinh commented Jul 10, 2024

I think grouping the journal entries can be made if the payslip_run_id is True by creating the payslip batch. And the journal entries will be created if all the payslip have been confirmed by user. By this case, we don't have to create field action_group_payslips. We are going to create PR for this case in V14 soon.

Thanks for your share. We prefer to keep the option for the company if they want to group the journal entries or not. This is because the payment might be global or individual... with a setup, it's more flexible

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants