[17.0][MIG] payroll_account: Migration to 17.0 #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: |
cvinh
suggested changes
Feb 9, 2024
| elif slip.contract_id.analytic_account_id: | ||
| move_line_analytic_ids.append( | ||
| (4, slip.contract_id.analytic_account_id.id) | ||
| ) |
There was a problem hiding this comment.
Please cherry pick #143
I tested ,on the side, after applying those proposals an all seems good and it is Functional OK.
Hopefully they are applied soon so this can be reviewed and approved.
hapolinario
force-pushed
the
17.0-mig-payroll-account
branch
2 times, most recently
from
bc1a63c
to
bf59830
Compare
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/ca/
Currently translated at 16.6% (4 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…or the payslip Until now this module tried to confirm an empty account move. This caused the account module to throw an exception. This causes problems in other modules that may not know about payroll_account. For example in other modules' tests.
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…cumentation [14.0] [IMP] payroll: improve salary rules views and documentation [14.0] [IMP] payroll: improve salary rules and categories views [14.0] [IMP] payroll: improve salary rules views and documentation [14.0] [IMP] payroll: improve salary rules views and documentation [IMP] payroll: fix repeated words [14.0] [IMP] payroll: fix typos
[14.0] [IMP] payroll: change manifest category [14.0] [IMP] payroll: add migration for new payslip and payslips objects [14.0] [IMP] payroll: add migration for new payslip and payslips objects [14.0] [IMP] payroll: add migration for new payslip and payslips objects
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/
Currently translated at 100.0% (21 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/fa/
Currently translated at 80.9% (17 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/it/
Currently translated at 85.7% (18 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/ar/
Currently translated at 85.7% (18 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/pt_BR/
Currently translated at 80.9% (17 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/
hapolinario
force-pushed
the
17.0-mig-payroll-account
branch
from
bf59830
to
34cf783
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.