[17.0][MIG] payroll: Migration to 17.0 #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit renames the module from hr_payroll to payroll. This is to avoid conflicting with the hr_payroll module included in Odoo Enterprise
Also removes links to localisations which have not yet been migrated. These can be re-added when the localisations are ported.
author nicolasrsande <[email protected]> 1643135061 -0300 committer nicolasrsande <[email protected]> 1643668459 -0300 fix typo in leave calculation default for worked days should not compute leaves, because leaves are calculated separately we should not add data because it interfers with custom localization payroll modules fix pre-commit add demo data so the test can be executed leaves should be computed in negative value to help creating salary rules Add mantainer key remove mantainer in payroll_account 14.0-minor-fixes fix typo in leave calculation we should not add data because it interfers with custom localization payroll modules fix pre-commit add demo data so the test can be executed leaves should be computed in negative value to help creating salary rules Add mantainer key remove mantainer in payroll_account 14.0-payroll-minor-fixes
accept suggestion use repr() on the string change indentation of error
Currently translated at 93.6% (266 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/
Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/
Currently translated at 86.9% (247 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/
Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/
Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/
Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/
Currently translated at 78.1% (222 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/it/
Currently translated at 100.0% (290 of 290 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/
The unittest for the payroll module is broken in several ways:
1. It doesn't actually test anything in the payslip, just the states
when various buttons are simulated
2. The payslip is created programatically, so no payslip values are loaded
3. The employee's contract is in "draft" state so even if it tried to
load any values it wouldn't work because the contract isn't "open"
4. It modifies a salary input line, but doesn't verify it worked. It
doesn't work because of the above mentioned reasons.
To ensure a minimal amount of testing:
o Make sure the employee's contract is in "open" state
o Use the "Form" testing object when creating a payslip to ensure
the onchange_employee() is run
o Actually test the payroll calculations are done correctly
…salary rule
A side effect of the way the payslip line quantity and rate are set when
amount_select is set to "code" causes them to never evaluate to zero. When they
evaluate to 0 the side effect causes them to be set to 1.0 and 100.0, respectively.
"result_qty" in localdict and localdict["result_qty"] or 1.0
"result_rate" in localdict and localdict["result_rate"] or 100.0
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/
Currently translated at 98.8% (354 of 358 strings) Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/fa/
Currently translated at 100.0% (358 of 358 strings) Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/
Currently translated at 57.2% (205 of 358 strings) Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll/
FernandoRomera
force-pushed
the
17.0-mig-payroll
branch
from
07def57
to
94e3587
Compare
|
Please follow the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 Specifically, please |
FernandoRomera
force-pushed
the
17.0-mig-payroll
branch
11 times, most recently
from
4b1e0d1
to
ddc2b16
Compare
FernandoRomera
force-pushed
the
17.0-mig-payroll
branch
from
ddc2b16
to
21e7d70
Compare
|
I am doing some functional tests and here is my first problem |
|
Display of Generates Payslip Batch Wizard is not good |
|
Hi, @FernandoRomera could you please comment on the status of this PR? I am interested in contributing to the migration. |
|
superseded by #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.