Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] dotfiles update needs manual intervention #132

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

etobella
Copy link
Member

Dear maintainer,

After updating the dotfiles, pre-commit run -a
fails in a manner that cannot be resolved automatically.

Can you please have a look, fix and merge?

Thanks,

@etobella etobella added the help wanted Extra attention is needed label Oct 27, 2023
@nimarosa
Copy link
Contributor

nimarosa commented Nov 7, 2023

@etobella pre-commit is failing because of the following changes needed:

****xml-deprecated-data-node****
payroll/security/hr_payroll_security.xml:3 Use `<odoo>` instead of `<odoo><data>` or use `<odoo noupdate="1">` instead of `<odoo><data noupdate="1">` - [xml-deprecated-data-node]
payroll/data/hr_payroll_sequence.xml:3 Use `<odoo>` instead of `<odoo><data>` or use `<odoo noupdate="1">` instead of `<odoo><data noupdate="1">` - [xml-deprecated-data-node]
payroll/data/hr_payroll_data.xml:3 Use `<odoo>` instead of `<odoo><data>` or use `<odoo noupdate="1">` instead of `<odoo><data noupdate="1">` - [xml-deprecated-data-node]

****xml-deprecated-qweb-directive****
payroll/views/report_contributionregister.xml:52 Deprecated QWeb directive `"t-esc-options"`. Use `"t-options"` instead - [xml-deprecated-qweb-directive]
payroll/views/report_contributionregister.xml:58 Deprecated QWeb directive `"t-esc-options"`. Use `"t-options"` instead - [xml-deprecated-qweb-directive]
payroll/views/report_contributionregister.xml:74 Deprecated QWeb directive `"t-esc-options"`. Use `"t-options"` instead - [xml-deprecated-qweb-directive]
payroll/views/report_payslipdetails.xml:104 Deprecated QWeb directive `"t-esc-options"`. Use `"t-options"` instead - [xml-deprecated-qweb-directive]
payroll/views/report_payslipdetails.xml:141 Deprecated QWeb directive `"t-esc-options"`. Use `"t-options"` instead - [xml-deprecated-qweb-directive]

****xml-deprecated-tree-attribute****
payroll/views/hr_payroll_structure_views.xml:7 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payroll_structure_views.xml:24 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_salary_rule_category_views.xml:49 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_contribution_register_views.xml:7 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_salary_rule_views.xml:7 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_salary_rule_views.xml:56 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_salary_rule_views.xml:219 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_line_views.xml:11 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_line_views.xml:84 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_views.xml:12 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_views.xml:197 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_views.xml:222 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_views.xml:2[71](https://github.com/OCA/payroll/actions/runs/6672953101/job/18137771165?pr=132#step:7:72) Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
payroll/views/hr_payslip_run_views.xml:38 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]

You can submit this PR updating the dotfiles and fixing what pre-commit is asking for it to pass. Then we can merge and all will be green again. The same in the other PR #133 for version 15.

@aleuffre aleuffre mentioned this pull request Jan 5, 2024
@OCA-git-bot OCA-git-bot merged commit a83859f into 14.0 Jan 5, 2024
8 of 11 checks passed
@OCA-git-bot OCA-git-bot deleted the 14.0-ocabot-update-dotfiles branch January 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants