[FIX] hr_payroll_period: remove warnings

OCA · Oct 23, 2023 · b3ddc0c · b3ddc0c
1 parent 4ef0f97
commit b3ddc0c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/hr_payroll_period/__manifest__.py b/hr_payroll_period/__manifest__.py
@@ -4,7 +4,7 @@
 
 {
     "name": "HR Payroll Period",
-    "version": "14.0.1.0.0",
+    "version": "14.0.1.0.1",
     "license": "AGPL-3",
     "category": "Payroll",
     "summary": "Add payroll periods",

diff --git a/hr_payroll_period/migrations/14.0.1.0.1/pre-migration.py b/hr_payroll_period/migrations/14.0.1.0.1/pre-migration.py
@@ -0,0 +1,11 @@
+from odoo.tools.sql import column_exists, rename_column
+
+
+def migrate(cr, version):
+    if column_exists(cr, "hr_contract", "shedule_pay"):
+        rename_column(
+            cr,
+            "hr_contract",
+            "shedule_pay",
+            "schedule_pay",
+        )
diff --git a/hr_payroll_period/models/hr_contract.py b/hr_payroll_period/models/hr_contract.py
@@ -11,6 +11,4 @@ class HrContract(models.Model):
     _inherit = "hr.contract"
 
     # Add semi-monthly to payroll schedules
-    schedule_pay = fields.Selection(
-        get_schedules, "Scheduled Pay", oldname="shedule_pay", index=True
-    )
+    schedule_pay = fields.Selection(get_schedules, "Scheduled Pay", index=True)
diff --git a/hr_payroll_period/models/hr_employee.py b/hr_payroll_period/models/hr_employee.py
@@ -7,7 +7,7 @@
 class HrEmployee(models.AbstractModel):
     _inherit = "hr.employee.base"
 
-    contract_id = fields.Many2one(search="_search_contract")
+    contract_id = fields.Many2one(comodel_name="hr.contract", search="_search_contract")
 
     @api.model
     def _search_contract(self, operator, value):