WIP: [ADD] event_rest_api #247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
reviewed
Dec 3, 2021
| event_ticket_id: int = None | ||
|
|
||
|
|
||
| class EventRegistrationParamList(models.BaseModel): |
There was a problem hiding this comment.
@qgroulard IMO This class should not exists.... Do you really need to nest a list as attribute of an other model?
lmignon
reviewed
Dec 3, 2021
event_rest_api/services/event.py
Outdated
|
|
||
| @restapi.method( | ||
| routes=[(["/<int:id>/registration"], "POST")], | ||
| input_param=PydanticModel(EventRegistrationParamList), |
There was a problem hiding this comment.
Why not PydanticModelList(EventRegistrationParam)?
There was a problem hiding this comment.
Because lists are not supported as parameters.
I can't figure out how to solve this. Or is PydanticModelList the way to go ?
Traceback (most recent call last):
File "/home/quentin/.virtualenvs/odoo-ecolo-14/lib/python3.6/site-packages/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
result = request.dispatch()
File "/home/quentin/.virtualenvs/odoo-ecolo-14/lib/python3.6/site-packages/odoo/http.py", line 807, in dispatch
r = self._call_function(**self.params)
Exception
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/quentin/Documents/oca/rest-framework/base_rest/http.py", line 182, in _handle_exception
return super(HttpRestRequest, self)._handle_exception(exception)
File "/home/quentin/.virtualenvs/odoo-ecolo-14/lib/python3.6/site-packages/odoo/http.py", line 745, in _handle_exception
return super(HttpRequest, self)._handle_exception(exception)
File "/home/quentin/.virtualenvs/odoo-ecolo-14/lib/python3.6/site-packages/odoo/http.py", line 316, in _handle_exception
raise exception.with_traceback(None) from new_cause
TypeError: _call_function() argument after ** must be a mapping, not list
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
lmignon
reviewed
Dec 3, 2021
qgroulard
force-pushed
the
14.0-event_rest_api-qgr
branch
8 times, most recently
from
6e43f8c
to
8358d1a
Compare
qgroulard
force-pushed
the
14.0-event_rest_api-qgr
branch
from
8358d1a
to
2d87e67
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbidoul
added
no stale
qgroulard
added a commit
to acsone/mozaik
that referenced
this pull request
Jul 19, 2023
marielejeune
pushed a commit
to acsone/mozaik
that referenced
this pull request
Sep 19, 2023
marielejeune
pushed a commit
to acsone/mozaik
that referenced
this pull request
Sep 20, 2023
marielejeune
pushed a commit
to acsone/mozaik
that referenced
this pull request
Sep 26, 2023
marielejeune
pushed a commit
to acsone/mozaik
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.