Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] product_contract #979

Merged
merged 156 commits into from
May 24, 2024
Merged

[15.0][MIG] product_contract #979

merged 156 commits into from
May 24, 2024

Conversation

adasatorres
Copy link

Ted Salmon and others added 30 commits July 26, 2023 13:12
[ADD] product_contract: Create module
1c44462 
* Add contract functionality to `product.templates`
* Add logic to create contracts from `sale.order` that contains contract products.
@lasley
[FIX] product_contract: Fix mock usage in tests
2296997
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
6f5e446 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
@sbejaoui
[MIG] - Product Contract Migration to 12.0
08e2c30
@sbejaoui
[IMP] - Product with is_contract can be only of type service
0a9bed1
@sbejaoui
[IMP] - Change dependencies to contract_sale
3c82c2c
@sbejaoui
[IMP] - Add recurrence fields to product template and sale order line
03b9d23
@sbejaoui
[IMP] - Create contract on sale order confirmation
33f6ad7 
- On Sale Order confirmation, a contract is created for each contract template used on sale order lines
- A not finished contract can be mentioned on sale order line
- A sale order line linked to a contract will update it and don't create a new one if it had the same template
@sbejaoui
[IMP] - Link contract line to sale order line
e6134d1
@sbejaoui
[FIX] - Remove recurring_next_date from sale order line
d44dff5 
recurring_next_date should be computed by contract line to get default value
@sbejaoui
[IMP] - Contract product are ignored on invoicing process
f7b0c0a 
- Sale order line for contract product pass to nothing to invoice on order confirmation
- Contract Invoices are linked to sale order line
@sbejaoui
[FIX] - Default value for date_start applied on product change
2a9745b
@sbejaoui
[ADD] - Add readme directory
81d336a
@sbejaoui
[IMP] - Onchange contract product on contract contract and contract t…
211f712 
…emplate
@sbejaoui
[FIX] - Change website to OCA repository url and prefix module name w…
7e26270 
…ith Recurring
@sbejaoui
[FIX] - Compute recurring_next_date before create contract line
b6d8644
@sbejaoui
[IMP] - Upsell/Downsell contract from sale order
1f15f63
@sbejaoui
[ADD] - Add renewal process with termination notice
881eb87
@sbejaoui
[IMP] - compute date end onchange date start for auto-renew sale orde…
737091c 
…r lines
@sbejaoui
[IMP] - link contract line and its successor in upsel case
7c9bbd9
@sbejaoui
[FIX] - on upsel, contract line should stop day - 1
2de8494
@sbejaoui
[FIX] - fix onchange
9538a7e
@sbejaoui
[IMP] - hide recurring_invoicing_type if recurring_rule_type is month…
6e76fdf 
…lylastday

for the monthlylastday case, pre-paid is logicly impossible,
if monthlylastday is set, we consider only post-paid case
@sbejaoui
[FIX] - include date_end in the period if the product is_autorenew
06a1c8a
@sbejaoui
[IMP] - _prepare_contract_value for sale order confirm
d2a58ae
@sbejaoui
[REM] - Remove unused method
7a79ad7
@sbejaoui
[IMP] - get contract user from sale order user
e6eceaa
@sbejaoui
[IMP] - show related sale orders in contract form
aac6878
@ThomasBinsfeld
[REF] Contract Product: invoice in prepare_invoice_line is optional
fe93bf4
@sbejaoui
[FIX] - fix flake8
864ab02
OCA-git-bot and others added 5 commits July 26, 2023 13:12
@OCA-git-bot
product_contract 14.0.1.1.0
0424a33
@weblate
Update translation files
9879860 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/
@mymage
Translated using Weblate (Italian)
40f3bc5 
Currently translated at 92.1% (47 of 51 strings)

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/it/
@mymage
Translated using Weblate (Italian)
7f72253 
Currently translated at 92.1% (47 of 51 strings)

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/it/
[15.0][IMP] product_contract : black, isort, prettier
0a0218c
@rousseldenis
Copy link
Contributor

/ocabot migration product_contract

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jul 26, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 21, 2023
Open
18 tasks
@Rad0van
Copy link
Contributor

Rad0van commented Sep 22, 2023

See #950 @rousseldenis has had comments that I believe are applicable here as well (onchange vs compute mainly)

@nileshsheliya
Copy link

@adasatorres I just check functionality, for sale order line form, it show dangling checkbox. Can we show it below Product with label.
image (32)

@Rad0van
Copy link
Contributor

Rad0van commented Nov 12, 2023

See #950 @rousseldenis has had comments that I believe are applicable here as well (onchange vs compute mainly)

Sorry, I meant #959

@pcastelovigo
Copy link

@adasatorres I just check functionality, for sale order line form, it show dangling checkbox. Can we show it below Product with label. image (32)

Perfect now, hopefully its merged

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions bot closed this May 19, 2024
@pedrobaeza pedrobaeza reopened this May 19, 2024
@pedrobaeza
Copy link
Member

Merging for not losing the migration

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-979-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ab9138 into OCA:15.0 May 24, 2024
8 of 13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0beef47. Thanks a lot for contributing to OCA. ❤️

@pcastelovigo pcastelovigo mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉 migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.