[16.0][IMP] subscription_oca: Various improvements #1058
Conversation
[IMP] subscription_oca: Various improvements
tarteo
force-pushed
the
16-imp-subscription_oca
branch
from
8473c8f
to
3851561
Compare
|
Not sure why the codecov/patch check is failing because codecov says there's a positive change (+0.03%)
|
tarteo
changed the title
| def action_open_subscription(self): | ||
| self.ensure_one() | ||
| action = self.env.ref("subscription_oca.sale_subscription_action") | ||
| action = action.read()[0] |
There was a problem hiding this comment.
Please use action = self.env["ir.actions.act_window"]._for_xml_id("subscription_oca.sale_subscription_action") instead.
| def close_subscription(self, close_reason_id=False): | ||
| self.ensure_one() | ||
| self.recurring_next_date = False | ||
| closed_stage = self.env["sale.subscription.stage"].search( |
There was a problem hiding this comment.
I don't really like selection with a limit=1. Is there a mean to restrict stage selection in a better way ?
There was a problem hiding this comment.
Propose a better solution
There was a problem hiding this comment.
Nevermind, don't bother, this will never be merged anyways...
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Fixes improvements mentioned here: #1057