fix: Publish config uses ES dist file

[Chocobozzz]

Use ES dist file as default export so consumer don't have to rebuild all files

Especially useful for consumers to not polyfill node dependencies of bittorrent-tracker dependency

[mrlika]

When publishing an npm package, the best practice is to export transpiled .js source files.

The package's consumers might have specific build processes or configurations. Providing the source files allows them to integrate a package seamlessly into their workflow regarding compatibility, flexibility, tree-shaking, etc.

For example, a node dependency polyfill may already be included in a codebase, and including it the second time makes the end application much bigger.

Can the bundled ES module be somehow exported as an alternative to the existing one? https://webpack.js.org/guides/package-exports/

[mrlika]

Something like:

 "exports": {
    ".": "./lib/index.js",
    "./esm": "./dist/p2p-media-loader-core.es.js"
  }

But this approach will also require somehow binding types to the "./esm" export.

[Chocobozzz]

I understand your point. However front-end libraries tend to ship the ES dist file by default (shaka player, hls.js or video.js do this kind of thing). It's also the recommended solution chosen by Vite: https://vite.dev/guide/build#library-mode

I suggest to use the exports method so consumers have the choice to use the source file, while specifying the ES module by default:

• Most devs don't want to spend time on mocking bittorrent-tracker server dependencies
• Your build process is good enough to tree-shake what p2p-media-loader doesn't need (especially the bittorrent-tracker server)
• Using a custom exports requires consumers to have specific tsconfig settings (moduleResolution/module options) that may not be compatible with their current setup
• Some frameworks (like Angular) don't allow to easily change the build setup to choose the appropriate file
• Devs that want build control should have enough knowledge to choose the appropriate exports

I updated the PR with my proposal.

[mrlika]

Thanks, we will test the proposed approach and give our feedback