Add missing data param in segment validator #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
force-pushed
the
feature/validator
branch
from
c88ca6c
to
f9540a3
Compare
DimaDemchenko
requested changes
Oct 25, 2024
Chocobozzz
force-pushed
the
feature/validator
branch
from
f9540a3
to
2a572b0
Compare
|
Thanks for the review, it's fixed! |
DimaDemchenko
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a typo in the documentation
Added
dataas last param to not break the API, even if I think passing theSegmentas first argument (as before) would better for future evolutions