Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds full support for RESP3 while keeping backwards compatibility. Most things should stay on par performance wise.
My intention here is to first fully support the spec and to improve the performance later on for the new data types. Especially as the logic would become increasingly difficult otherwise due to the new attribute type (data that should be ignored while delivering it to the user in an unspecified way).
I have no strong opinion about the way
push data
andattributes
is implemented and I am happy to get some input about those.@luin @Salakar PTAL