tabby: 0.11.1 -> 0.18.0 #350323
Open
tabby: 0.11.1 -> 0.18.0 #350323
+2,001
−1,916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently will pick up whichever version of release is available first. Limit to non prefixed version releases. Can fail because atom feed might not contain the proper version we track.
khaneliman
force-pushed
the
tabby
branch
3 times, most recently
from
5745d47
to
b4f9e7e
Compare
|
Sorry, marking draft for now. Adding versionCheckHook broke compilation and wanted to double check whether we could keep using our own tabby-server derivation output instead of building it again in this. |
|
1 similar comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to latest tabby release.
They moved from generating cpp bindings to just building the llama-server beside tabby. Since we already have a derivation that builds llama-server, we can link its output to the generated location tabby looks.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.