angular-language-server-bin: init at 18.2.0 #350257
Open
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tricktron
force-pushed
the
f-angular-ls-bin
branch
from
425e0ab
to
6f8b136
Compare
13 tasks
| description = "LSP for angular completions, AOT diagnostic, quick info and go to definitions"; | ||
| homepage = "https://github.com/angular/vscode-ng-language-service"; | ||
| changelog = "https://github.com/angular/vscode-ng-language-service/blob/${finalAttrs.version}/CHANGELOG.md"; | ||
| license = lib.licenses.mit; |
There was a problem hiding this comment.
Not sure if we have an appropriate sourceProvenance for prebuild js things.
| ]; | ||
| text = '' | ||
| LATEST_VERSION=$(curl -H "Accept: application/vnd.github+json" \ | ||
| -Ls https://api.github.com/repos/${owner}/${repo}/releases/latest | \ |
There was a problem hiding this comment.
This should optionally take a GITHUB_TOKEN
| passthru = { | ||
| tests = { | ||
| start-ok = runCommand "${finalAttrs.pname}-test" { } '' | ||
| ${angular-language-server-bin}/bin/ngserver --stdio --help &> $out |
There was a problem hiding this comment.
We can use lib.getExe here and grep in one go
| installPhase = '' | ||
| runHook preInstall | ||
| install -Dm755 server/bin/ngserver $out/bin/ngserver | ||
| install -Dm755 server/index.js $out/index.js |
There was a problem hiding this comment.
Can we place those not at /?
| }: | ||
|
|
||
| let | ||
| owner = "angular"; |
There was a problem hiding this comment.
Just hardcore those. They will likely never ever change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages the angular language server as binary because packaging from source is especially difficult (see #349521 for more details).
Closes #244019.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.