Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro-language-server: 2.15.0 -> 2.15.3 #349343

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Oct 17, 2024

Fixes #349336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Atemu
Copy link
Member

Atemu commented Oct 21, 2024

This needs to be rebased atop of #349093.

@Atemu Atemu requested a review from Scrumplex October 21, 2024 11:32
@pyrox0
Copy link
Member Author

pyrox0 commented Oct 21, 2024

This needs to be rebased atop of #349093.

Done

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Builds and runs

@Scrumplex Scrumplex merged commit d7d545c into NixOS:master Oct 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: astro-language-server 2.15.0 -> 2.15.3
4 participants