Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

razer-cli: init at 2024-04-04 #348822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

razer-cli: init at 2024-04-04 #348822

wants to merge 3 commits into from

Conversation

KaylorBen
Copy link

Python CLI utility to control various razer devices via openrazer. Useful for changing mouse dpi, rgb, etc with command line and user scripts/services.
https://github.com/LoLei/razer-cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Noodlez1232
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348822


x86_64-linux

✅ 2 packages built:
  • razer-cli
  • razer-cli.dist

@Noodlez1232
Copy link
Contributor

It's worth noting that this requires openrazer running.
Maybe in the future create a module with an option programs.razer-cli.enable that will also enable openrazer? Not a blocker though this looks good to me.

@KaylorBen
Copy link
Author

KaylorBen commented Oct 16, 2024

It's worth noting that this requires openrazer running. Maybe in the future create a module with an option programs.razer-cli.enable that will also enable openrazer? Not a blocker though this looks good to me.

Ye that could be a good idea, currently just a comment but that isn't user facing of course. Could also be an option within the hardware.openrazer module, although I'm not sure if that is more or less correct than creating a new module

@Noodlez1232
Copy link
Contributor

Could also be an option within the hardware.openrazer module

Hmm I don't think this is a bad idea either. Like hardware.openrazer.razer-cli.enable

@KaylorBen
Copy link
Author

Should probably be up to the maintainer of openrazer module @roelvandijk if this makes sense. Otherwise I think there is plenty of convention of packages which do not work without various services behaving in a certain way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants