nixos/tun2socks: init #348055
Open
nixos/tun2socks: init #348055
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaleocheng
force-pushed
the
services-tun2socks
branch
from
5ad9cc7
to
3b0cc2a
Compare
|
@SuperSandro2000 are you able to review this ? |
| cfg = config.services.tun2socks; | ||
| settingsFormat = pkgs.formats.yaml { }; | ||
| in | ||
| with lib; |
There was a problem hiding this comment.
Suggested change
| with lib; |
we don't do that anymore
| User = cfg.user; | ||
| Group = cfg.group; | ||
| Type = "simple"; | ||
| ExecStart = "${getBin cfg.package}/bin/tun2socks -config ${cfg.configFile}"; |
There was a problem hiding this comment.
Suggested change
| ExecStart = "${getBin cfg.package}/bin/tun2socks -config ${cfg.configFile}"; | |
| ExecStart = "${lib.getExe getBin cfg.package} -config ${cfg.configFile}"; |
| description = "Path to tun2socks YAML configuration file."; | ||
| }; | ||
|
|
||
| package = mkOption { |
There was a problem hiding this comment.
Please use mkPackageOption
|
|
||
| configFile = mkOption { | ||
| default = settingsFormat.generate "/var/lib/tun2socks/config.yaml" cfg.settings; | ||
| defaultText = "A tun2socks configuration file automatically generated by values from services.tun2socks.settings.*"; |
There was a problem hiding this comment.
Suggested change
| defaultText = "A tun2socks configuration file automatically generated by values from services.tun2socks.settings.*"; | |
| defaultText = "A tun2socks configuration file automatically generated by values from services.tun2socks.settings"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service for https://github.com/xjasonlyu/tun2socks
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.