ddnet: 18.4 -> 18.6 #346915
Open
ddnet: 18.4 -> 18.6 #346915
+3
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
reviewed
Oct 20, 2024
pkgs/games/ddnet/default.nix
Outdated
Comment on lines
95
to
100
| # patches = [ | ||
| # (fetchpatch { | ||
| # url = "https://github.com/ddnet/ddnet/pull/8517/commits/c840bf45016a30e629f7684df5fab5d07b2c70d5.patch"; | ||
| # hash = "sha256-UG7pi0Xh/nAHFEF1RIyNZLewF+NFilTLARbV5oUlftc="; | ||
| # }) | ||
| # ]; |
There was a problem hiding this comment.
Could you remove these line completely?
Suggested change
| # patches = [ | |
| # (fetchpatch { | |
| # url = "https://github.com/ddnet/ddnet/pull/8517/commits/c840bf45016a30e629f7684df5fab5d07b2c70d5.patch"; | |
| # hash = "sha256-UG7pi0Xh/nAHFEF1RIyNZLewF+NFilTLARbV5oUlftc="; | |
| # }) | |
| # ]; |
There was a problem hiding this comment.
very good idea, i removed the commted out lines
|
in the next months will be quite busy, so right now that feels not like a good idea to me (e.g. i had no time to do 18.5) |
Scrumplex
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ddnet.org/downloads/#18.6
ddnet/ddnet@18.4...18.6
removed patch (PR ddnet/ddnet#8517 Fix gcc format-security warnings on build) that is not longer needed to compile.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.