-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-authentication-service: init at 0.7.0 #275057
matrix-authentication-service: init at 0.7.0 #275057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I've packaged this before, see https://github.com/NickCao/flakes/blob/master/pkgs/matrix-authentication-service/default.nix for some ideas to steal from.
0881c99
to
9cd3ca2
Compare
Thanks, I liked your version a lot and stole a lot (if not all 😄). |
Tool to help with the migration of a Matrix Synapse installation to the Matrix Authentication Service. https://github.com/matrix-org/matrix-authentication-service/tree/main/tools/syn2mas Related to NixOS#275057
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need a nixos test for this, it's a complicated piece of software. Otherwise LGTM.
Do you mean a simple version test? In case you think of something more complex, can you point me to an example? |
Something like |
MAS (Matrix Authentication Service) is an OAuth 2.0 and OpenID Provider server for Matrix https://github.com/matrix-org/matrix-authentication-service/releases/tag/v0.7.0 Co-authored-by: Nick Cao <[email protected]>
9cd3ca2
to
05e00f6
Compare
Was missing I started something regarding module / test in this branch: teutat3s@287fbae |
Tool to help with the migration of a Matrix Synapse installation to the Matrix Authentication Service. https://github.com/matrix-org/matrix-authentication-service/tree/main/tools/syn2mas Related to NixOS#275057
@teutat3s are you planning to add the module to this PR or should we move forward with the package alone? |
@adamcstephens I'm still working on the module and might be able to look into it some more in the coming week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 275057
run on x86_64-linux 1
1 package built:
- matrix-authentication-service
Result of nixpkgs-review pr 275057
run on aarch64-darwin 1
1 package built:
- matrix-authentication-service
Result of nixpkgs-review pr 275057
run on x86_64-darwin 1
1 package built:
- matrix-authentication-service
Result of nixpkgs-review pr 275057
run on aarch64-linux 1
1 package built:
- matrix-authentication-service
Description of changes
MAS (Matrix Authentication Service) is an OAuth 2.0 and OpenID Provider server for Matrix.
It has been created to support the migration of Matrix to an OpenID Connect (OIDC) based authentication layer as per MSC3861.
One can learn more about Matrix and OIDC at areweoidcyet.com.
https://github.com/matrix-org/matrix-authentication-service/releases/tag/v0.7.0
Vendoring the
Cargo.lock
is necessary because of a dependency they use:opa-wasm-0.1.0
(pinned to a git repo) .Future work:
For this to be really useful, a NixOS module will be needed.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.